← dashboard

nccommon

model: opus-4-8 cpp static analysis on 0 PR(s) seen
workspaceninjarmm jira projectNJ review targetsmain · master · develop · release/* · *_release thresholdsseverity ≥ minor · confidence ≥ medium · cap 12 max diff0.4 MB pollevery 300s

What this is

Shared C++ library, a submodule of BOTH ncpeer and nmsnj: common crypto, protocol/transport bits, USB, input, scrolling, platform helpers. A change here ripples into both products.

Project primer

Durable orientation injected into every review as .ai-review/project.md.

nccommon — shared session/crypto library (review primer)

Shared C++/Qt library (a submodule of BOTH ncpeer and nmsnj) that owns the
session-layer protocol and cryptography: the wire Envelope, the per-channel message
types, and the crypto primitives. The consuming products cannot communicate without it, so
its wire format and crypto are cross-repo, cross-version contracts.

Architecture (durable map)

bridges (Apple, Android) — multiple backends that must be byte-for-byte equivalent.

(IP ACL, session-token / DUT helpers, common types).

What matters most when reviewing here (durable risk areas)

retyping a serialized field silently corrupts deserialization for peers on other versions.

interoperate, or cross-platform sessions fail silently.

Scrutinize any change near nonce assignment.

tag is an auth bypass.

both — weigh both consumers.

Security-sensitive zones

Key exchange (ECDH/X25519) + AEAD; the platform crypto bridges (an encoding mismatch yields a
wrong shared secret); the Envelope MAC tags; the IP ACL and session-token signing.

Compatibility surfaces (contracts that must not silently break)

types — respect it).

Conventions & gotchas

others to keep bytes identical.

for blast radius.

_Orientation only — verify current specifics in the code; this describes durable architecture &
risk areas, not a snapshot._

Ecosystem map

Shared cross-project relationships, injected as .ai-review/ecosystem.md.

NinjaRemote / NinjaOne project ecosystem (relationship map)

How the monitored repos relate — so a change in one repo is reviewed with its blast
radius in mind (a change upstream of ncpeer can break ncpeer even if it looks local).
Orientation only; verify specifics in code.

NinjaRemote product

speak the NCRP wire protocol (protocol/format changes must stay compatible across
client and server versions).

Cloud-side relays of the ninja-remote system (AWS-hosted, Python/Go)

URLs, it pairs them and forwards frames verbatim. Signed join URLs are minted by the
Ninja backend — the signature scheme is a backend⇄relay contract, and the frame
semantics are a peer⇄peer contract.

a signed upload leg streams to a signed download leg through memory (never stored).
Two parallel implementations (Python ftsv2/ + Go fts_go/) must stay behaviorally
identical; the URL/signature scheme is shared-family with websocket-switch.
NinjaRemote file-transfer features ride on these relays when peers can't go direct.

Pulled INTO ncpeer (and sometimes nmsnj) — upstream of the products

or behaviour change here affects both consumers.

build against**. A dependency bump changes what those products link (security/ABI/build).

through the ncpeer_vcpkg overlay.

Largely independent

shares nccommon and ncpeer_vcpkg with ncpeer.

part of the remote-desktop family). Runs as a child process of the NinjaRMM agent (the
parent owns install/upgrade/policy/launch); NinjaFlow owns the CLI contract, config schema,
credential precedence, DB schema/migrations, and exit-code meanings the parent consumes
those are cross-process contracts. Submits telemetry to the Ninja Backend. Shares no code with
ncpeer/nmsnj; adjacent to nmsnj only in domain (network), not in implementation.

not part of any product's build. It consumes the SBOMs the other products' pipelines emit
(Ninja-Remote/ncpeer, NMS/nmsnj, NinjaFlow all appear in its scope maps), scans them for CVEs
and files Jira issues — a downstream *security-scanning* relationship, not a code dependency.
Shares no code with the others; has its own DB/schema and a toolbox submodule.

authentication component: its pam_ninja.so gates SSH reverse-tunnel access into
Ninja infrastructure with a time-based OTP. Shares no code with the other repos; its
blast radius is operational (who can SSH-tunnel into hosts), not code-level. The client OTP
generators and the module must agree on the OTP scheme + shared secret.

Review implications

these are *upstream* of ncpeer (and nccommon/vcpkg also of nmsnj) — weigh the consumer
side: API/ABI compatibility, build impact, and cross-platform reach.

contract.

Also in every review's context

The reviewer instructions CLAUDE.md (rules, house C++ style, output schema); the PR/ticket block pr.md (title, description, linked Jira + acceptance criteria, commits, changed files); the full diff.patch; and deterministic static_analysis.md (cppcheck on changed lines).