← dashboard

qclauncher

model: (cli default) cpp static analysis on 0 PR(s) seen
workspaceninjarmm jira projectNJ review targetsmaster · main · *_release · release/* thresholdsseverity ≥ minor · confidence ≥ medium · cap 12 max diff0.4 MB pollevery 300s

What this is

QC Launcher — Quick Connect launcher client that bootstraps and runs the NinjaRemote quick-connect session. Qt/C++.

Project primer

Durable orientation injected into every review as .ai-review/project.md.

qclauncher — QC Launcher (review primer)

Customer-facing Qt6/C++ desktop app (Windows and macOS) that bootstraps a NinjaRemote
Quick Connect session: it registers/authenticates the device with the NinjaOne backend over
WAMP/WebSocket + TLS, then on backend command fetches, integrity-verifies, installs,
and launches the ncstreamer process (also handles RMM agent install + self-cleanup). qmake.

Architecture (durable map)

(invitation-code flow), verifies its hash, unpacks, launches it, reports, self-cleans.

RPC action handlers the backend calls to start / start-as-user / install-agent /
uninstall; launcher/internal/ process + bootstrap helpers (elevation, run-as-user, IPC).

What matters most here (durable risk areas)

derived from downloads/config — shell-injection and TOCTOU surface; server-supplied
content must never be shell-interpolated.

written to a session file and passed to ncstreamer — verify nothing is shell-interpolated
and the temp file isn't world-readable/writable.

check must be un-skippable on every error / early-quit path.

is deleted on a timer, not immediately — wrong perms, leaks, or a missed timer expose it.

needed and never expose credentials in argv or logs.

check on a new handler is high-severity.

Security-sensitive zones

The macOS shell-out paths; credential handling in the start-as-user flow and the sudo wrapper;
bootstrap-arg parsing from an elevated process; proxy credentials.

Compatibility surfaces (must not silently break)

result/error tuples are a contract with the backend.

with a filename-based fallback) — packaging/signing changes can break param extraction.

Conventions & gotchas

paths (hangs).

_Orientation only — verify current specifics in the code; this describes durable architecture
and risk areas, not a snapshot._

Ecosystem map

Shared cross-project relationships, injected as .ai-review/ecosystem.md.

NinjaRemote / NinjaOne project ecosystem (relationship map)

How the monitored repos relate — so a change in one repo is reviewed with its blast
radius in mind (a change upstream of ncpeer can break ncpeer even if it looks local).
Orientation only; verify specifics in code.

NinjaRemote product

speak the NCRP wire protocol (protocol/format changes must stay compatible across
client and server versions).

Cloud-side relays of the ninja-remote system (AWS-hosted, Python/Go)

URLs, it pairs them and forwards frames verbatim. Signed join URLs are minted by the
Ninja backend — the signature scheme is a backend⇄relay contract, and the frame
semantics are a peer⇄peer contract.

a signed upload leg streams to a signed download leg through memory (never stored).
Two parallel implementations (Python ftsv2/ + Go fts_go/) must stay behaviorally
identical; the URL/signature scheme is shared-family with websocket-switch.
NinjaRemote file-transfer features ride on these relays when peers can't go direct.

Pulled INTO ncpeer (and sometimes nmsnj) — upstream of the products

or behaviour change here affects both consumers.

build against**. A dependency bump changes what those products link (security/ABI/build).

through the ncpeer_vcpkg overlay.

Largely independent

shares nccommon and ncpeer_vcpkg with ncpeer.

part of the remote-desktop family). Runs as a child process of the NinjaRMM agent (the
parent owns install/upgrade/policy/launch); NinjaFlow owns the CLI contract, config schema,
credential precedence, DB schema/migrations, and exit-code meanings the parent consumes
those are cross-process contracts. Submits telemetry to the Ninja Backend. Shares no code with
ncpeer/nmsnj; adjacent to nmsnj only in domain (network), not in implementation.

not part of any product's build. It consumes the SBOMs the other products' pipelines emit
(Ninja-Remote/ncpeer, NMS/nmsnj, NinjaFlow all appear in its scope maps), scans them for CVEs
and files Jira issues — a downstream *security-scanning* relationship, not a code dependency.
Shares no code with the others; has its own DB/schema and a toolbox submodule.

authentication component: its pam_ninja.so gates SSH reverse-tunnel access into
Ninja infrastructure with a time-based OTP. Shares no code with the other repos; its
blast radius is operational (who can SSH-tunnel into hosts), not code-level. The client OTP
generators and the module must agree on the OTP scheme + shared secret.

Review implications

these are *upstream* of ncpeer (and nccommon/vcpkg also of nmsnj) — weigh the consumer
side: API/ABI compatibility, build impact, and cross-platform reach.

contract.

Also in every review's context

The reviewer instructions CLAUDE.md (rules, house C++ style, output schema); the PR/ticket block pr.md (title, description, linked Jira + acceptance criteria, commits, changed files); the full diff.patch; and deterministic static_analysis.md (cppcheck on changed lines).